chore: refactor eotsd keys cmd #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitferry
requested review from
SebastianElvis,
RafilxTenfen and
KonradStaniec
KonradStaniec
approved these changes
Oct 24, 2024
eotsmanager/cmd/eotsd/utils.go
Outdated
| // and exists a value in the config that could be used, it will be set in the ctx. | ||
| func PersistClientCtx(ctx client.Context) func(cmd *cobra.Command, _ []string) error { | ||
| return func(cmd *cobra.Command, _ []string) error { | ||
| // TODO(verify): if it uses the default encoding config it fails to list keys! output: |
There was a problem hiding this comment.
oh do we have some test case for this ? or this is cosmos-sdk bug and we do not need to do anything with this ?
There was a problem hiding this comment.
Oh I copied it from
. Any ideas? @RafilxTenfen
There was a problem hiding this comment.
Oh, yeah I remembered
I only create the whole app to get the configs to ctx
tempApp := app.NewTmpBabylonApp()
ctx = ctx.
WithCodec(tempApp.AppCodec()).
WithInterfaceRegistry(tempApp.InterfaceRegistry()).
WithTxConfig(tempApp.TxConfig()).
WithLegacyAmino(tempApp.LegacyAmino()).
WithInput(os.Stdin)If we use the appparams.DefaultEncodingConfig() instead of tempApp := app.NewTmpBabylonApp() it fails
There was a problem hiding this comment.
I think we need to add std.RegisterInterfaces(encCfg.InterfaceRegistry). Otherwise, it does not how to decode the key. See the fix in 942df6e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #63:
eotsdcli library withcobralib to be consistent withfpdexport-popandsign-schnorrbecause they are not needed for phase-2keyscommands fromcosmos-sdkkeys addcommands to save the public key and key name wrappingExample after change: